giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update migration logic and set default NPC targetability to true in tests

Browse Source
This commit is contained in:
Victor Giers
2026-05-11 21:34:51 +02:00
parent 3b4302c4a4
commit c30aa4fbc8
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/document/migrate-scene-document.ts
View File

@@ -5240,9 +5240,7 @@ function migrateLegacySceneNpcTargetability(
): SceneDocument { ): SceneDocument {
const targetableNpcIds = new Set( const targetableNpcIds = new Set(
Object.values(document.interactionLinks) Object.values(document.interactionLinks)
.filter((link) => .filter(hasLegacyNpcTargetingInteractionLink)
hasLegacyNpcTargetingInteractionLink(link, document.sequences)
)
.map((link) => link.sourceEntityId) .map((link) => link.sourceEntityId)
); );
@@ -5292,9 +5290,7 @@ function migrateLegacyProjectNpcTargetability(
for (const [sceneId, scene] of Object.entries(document.scenes)) { for (const [sceneId, scene] of Object.entries(document.scenes)) {
const targetableNpcIds = new Set( const targetableNpcIds = new Set(
Object.values(scene.interactionLinks) Object.values(scene.interactionLinks)
.filter((link) => .filter(hasLegacyNpcTargetingInteractionLink)
hasLegacyNpcTargetingInteractionLink(link, document.sequences)
)
.map((link) => link.sourceEntityId) .map((link) => link.sourceEntityId)
); );

2
tests/unit/entity-instances.test.ts
View File

@@ -173,7 +173,7 @@ describe("entity registry defaults", () => {
expect(createDefaultEntityInstance("npc")).toMatchObject({ expect(createDefaultEntityInstance("npc")).toMatchObject({
kind: "npc", kind: "npc",
position: { x: 0, y: 0, z: 0 }, position: { x: 0, y: 0, z: 0 },
targetable: false, targetable: true,
yawDegrees: DEFAULT_NPC_YAW_DEGREES, yawDegrees: DEFAULT_NPC_YAW_DEGREES,
modelAssetId: null modelAssetId: null
}); });