From c30aa4fbc84ef3f9da198b31f27bca9d1fe340d4 Mon Sep 17 00:00:00 2001 From: Victor Giers Date: Mon, 11 May 2026 21:34:51 +0200 Subject: [PATCH] Update migration logic and set default NPC targetability to true in tests --- src/document/migrate-scene-document.ts | 8 ++------ tests/unit/entity-instances.test.ts | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/document/migrate-scene-document.ts b/src/document/migrate-scene-document.ts index f47ff9b1..d68c066f 100644 --- a/src/document/migrate-scene-document.ts +++ b/src/document/migrate-scene-document.ts @@ -5240,9 +5240,7 @@ function migrateLegacySceneNpcTargetability( ): SceneDocument { const targetableNpcIds = new Set( Object.values(document.interactionLinks) - .filter((link) => - hasLegacyNpcTargetingInteractionLink(link, document.sequences) - ) + .filter(hasLegacyNpcTargetingInteractionLink) .map((link) => link.sourceEntityId) ); @@ -5292,9 +5290,7 @@ function migrateLegacyProjectNpcTargetability( for (const [sceneId, scene] of Object.entries(document.scenes)) { const targetableNpcIds = new Set( Object.values(scene.interactionLinks) - .filter((link) => - hasLegacyNpcTargetingInteractionLink(link, document.sequences) - ) + .filter(hasLegacyNpcTargetingInteractionLink) .map((link) => link.sourceEntityId) ); diff --git a/tests/unit/entity-instances.test.ts b/tests/unit/entity-instances.test.ts index 6a29aa97..ea0ea3be 100644 --- a/tests/unit/entity-instances.test.ts +++ b/tests/unit/entity-instances.test.ts @@ -173,7 +173,7 @@ describe("entity registry defaults", () => { expect(createDefaultEntityInstance("npc")).toMatchObject({ kind: "npc", position: { x: 0, y: 0, z: 0 }, - targetable: false, + targetable: true, yawDegrees: DEFAULT_NPC_YAW_DEGREES, modelAssetId: null });