giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve target look offset limits and add boundary detection logic

Browse Source
This commit is contained in:
Victor Giers
2026-04-25 17:26:39 +02:00
parent d2f2b38f34
commit 98610c53d3
1 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/runtime-three/third-person-navigation-controller.ts
View File

@@ -46,8 +46,8 @@ const TARGET_ASSIST_VERTICAL_COLLISION_FADE_END_RATIO = 0.72;
const TARGET_LOOK_OFFSET_GAMEPAD_SPEED = 1.15;
const TARGET_LOOK_OFFSET_POINTER_SENSITIVITY = 0.004;
const TARGET_LOOK_OFFSET_RETURN_SPEED = 5.5;
const TARGET_LOOK_OFFSET_YAW_LIMIT = 0.26;
const TARGET_LOOK_OFFSET_PITCH_LIMIT = 0.16;
const TARGET_LOOK_OFFSET_YAW_LIMIT = 0.75;
const TARGET_LOOK_OFFSET_PITCH_LIMIT = 0.42;
const POINTER_TARGET_LOOK_INPUT_SCALE = 0.06;
function clampPitch(pitchRadians: number): number {
@@ -592,6 +592,29 @@ export class ThirdPersonNavigationController implements NavigationController {
this.publishTelemetry();
}
private applyTargetLookOffsetDelta(yawDelta: number, pitchDelta: number) {
const nextYaw = this.targetLookOffsetYawRadians + yawDelta;
const nextPitch = this.targetLookOffsetPitchRadians + pitchDelta;
const clampedYaw = Math.max(
-TARGET_LOOK_OFFSET_YAW_LIMIT,
Math.min(TARGET_LOOK_OFFSET_YAW_LIMIT, nextYaw)
);
const clampedPitch = Math.max(
-TARGET_LOOK_OFFSET_PITCH_LIMIT,
Math.min(TARGET_LOOK_OFFSET_PITCH_LIMIT, nextPitch)
);
const boundaryReached = clampedYaw !== nextYaw || clampedPitch !== nextPitch;
this.targetLookOffsetYawRadians = clampedYaw;
this.targetLookOffsetPitchRadians = clampedPitch;
if (boundaryReached) {
this.context?.handleRuntimeTargetLookBoundaryReached?.();
this.targetLookOffsetYawRadians = 0;
this.targetLookOffsetPitchRadians = 0;
}
}
private updateCameraTransform() {
if (this.context === null) {
return;