giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor box create preview handling in ViewportHost

Browse Source
This commit is contained in:
Victor Giers
2026-04-02 23:02:19 +02:00
parent f1714a4c2a
commit 856dd76669
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/viewport-three/viewport-host.ts
View File

@@ -186,7 +186,7 @@ export class ViewportHost {
private container: HTMLElement | null = null;
private brushSelectionChangeHandler: ((selection: EditorSelection) => void) | null = null;
private createBoxBrushHandler: ((center: Vec3) => void) | null = null;
private boxCreatePreviewHandler: ((center: Vec3 | null) => void) | null = null;
private boxCreatePreviewChangeHandler: ((center: Vec3 | null) => void) | null = null;
private toolMode: ToolMode = "select";
private viewMode: ViewportViewMode = "perspective";
private displayMode: ViewportDisplayMode = "normal";
@@ -292,9 +292,12 @@ export class ViewportHost {
this.createBoxBrushHandler = handler;
}
setBoxCreatePreviewHandler(handler: ((center: Vec3 | null) => void) | null) {
this.boxCreatePreviewHandler = handler;
handler?.(this.lastBoxCreatePreviewCenter);
setBoxCreatePreviewChangeHandler(handler: ((center: Vec3 | null) => void) | null) {
this.boxCreatePreviewChangeHandler = handler;
}
setBoxCreatePreview(center: Vec3 | null) {
this.syncBoxCreatePreview(center);
}
setToolMode(toolMode: ToolMode) {
@@ -303,7 +306,7 @@ export class ViewportHost {
this.lastClickSelectionKey = null;
if (toolMode !== "box-create") {
this.setBoxCreatePreview(null);
this.syncBoxCreatePreview(null);
}
}
@@ -316,10 +319,6 @@ export class ViewportHost {
this.lastClickPointer = null;
this.lastClickSelectionKey = null;
if (this.toolMode === "box-create") {
this.setBoxCreatePreview(null);
}
this.applyViewModePose();
if (this.currentAdvancedRenderingSettings !== null) {
@@ -393,8 +392,8 @@ export class ViewportHost {
this.clearLocalLights();
this.clearBrushMeshes();
this.clearEntityMarkers();
this.boxCreatePreviewHandler = null;
this.setBoxCreatePreview(null);
this.boxCreatePreviewChangeHandler = null;
this.syncBoxCreatePreview(null);
this.advancedRenderingComposer?.dispose();
this.advancedRenderingComposer = null;
this.currentAdvancedRenderingSettings = null;
@@ -1571,6 +1570,10 @@ export class ViewportHost {
}
private setBoxCreatePreview(center: Vec3 | null) {
this.syncBoxCreatePreview(center);
}
private syncBoxCreatePreview(center: Vec3 | null) {
if (
(center === null && this.lastBoxCreatePreviewCenter === null) ||
(center !== null &&
@@ -1591,7 +1594,7 @@ export class ViewportHost {
this.boxCreatePreviewEdges.position.set(center.x, center.y, center.z);
}
this.boxCreatePreviewHandler?.(this.lastBoxCreatePreviewCenter);
this.boxCreatePreviewChangeHandler?.(this.lastBoxCreatePreviewCenter);
}
private render = () => {