giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement selection change handling in ViewportHost, triggering refresh of paths, markers, and model instances, and update related integration tests.

Browse Source
This commit is contained in:
Victor Giers
2026-04-27 00:02:26 +02:00
parent ac815f4260
commit 7fb757ee1c
12 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/viewport-three/viewport-host.ts
View File

@@ -6887,6 +6887,21 @@ export class ViewportHost {
this.whiteboxHoverLabelChangeHandler?.(label);
}
private refreshSelectionPresentation() {
if (this.currentDocument === null) {
return;
}
this.refreshBrushPresentation();
this.refreshTerrainPresentation();
this.rebuildPaths(this.currentDocument, this.currentSelection);
this.rebuildEntityMarkers(this.currentDocument, this.currentSelection);
this.rebuildModelInstances(this.currentDocument, this.currentSelection);
this.applyTransformPreview();
this.syncTransformGizmo();
this.syncTerrainBrushPreview();
}
private setHoveredSelection(selection: EditorSelection) {
if (areEditorSelectionsEqual(this.hoveredSelection, selection)) {
return;

2
tests/unit/app-project-persistence.integration.test.tsx
View File

@@ -11,6 +11,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
setDisplayMode: ReturnType<typeof vi.fn>;
@@ -40,6 +41,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setViewMode = vi.fn();
setDisplayMode = vi.fn();
setGridVisible = vi.fn();

2
tests/unit/app-scene-transition.integration.test.tsx
View File

@@ -19,6 +19,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateWorld: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
updateSimulation: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -48,6 +49,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateWorld = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
updateSimulation = vi.fn();
setViewMode = vi.fn();
setDisplayMode = vi.fn();

2
tests/unit/interaction-links.inspector.integration.test.tsx
View File

@@ -10,6 +10,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -39,6 +40,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setPanelId = vi.fn();
setRenderEnabled = vi.fn();
setViewMode = vi.fn();

2
tests/unit/light-volume.integration.test.tsx
View File

@@ -19,6 +19,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setGridVisible: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -48,6 +49,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setRenderEnabled = vi.fn();
setGridVisible = vi.fn();
setViewMode = vi.fn();

2
tests/unit/path-inspector.integration.test.tsx
View File

@@ -9,6 +9,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -38,6 +39,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setPanelId = vi.fn();
setRenderEnabled = vi.fn();
setViewMode = vi.fn();

2
tests/unit/path-point-editing.integration.test.tsx
View File

@@ -20,6 +20,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -50,6 +51,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setPanelId = vi.fn((panelId: string) => {
this.panelId = panelId;
});

2
tests/unit/player-start-inspector.integration.test.tsx
View File

@@ -10,6 +10,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -39,6 +40,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setPanelId = vi.fn();
setRenderEnabled = vi.fn();
setViewMode = vi.fn();

2
tests/unit/terrain-foundation.integration.test.tsx
View File

@@ -9,6 +9,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setPanelId: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -38,6 +39,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setPanelId = vi.fn();
setRenderEnabled = vi.fn();
setViewMode = vi.fn();

2
tests/unit/transform-foundation.integration.test.tsx
View File

@@ -29,6 +29,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
setDisplayMode: ReturnType<typeof vi.fn>;
setCameraState: ReturnType<typeof vi.fn>;
@@ -61,6 +62,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setViewMode = vi.fn();
setDisplayMode = vi.fn();
setCameraState = vi.fn();

2
tests/unit/viewport-canvas.test.tsx
View File

@@ -32,6 +32,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
setDisplayMode: ReturnType<typeof vi.fn>;
setCameraState: ReturnType<typeof vi.fn>;
@@ -63,6 +64,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setViewMode = vi.fn();
setDisplayMode = vi.fn();
setCameraState = vi.fn();

2
tests/unit/water-volume.integration.test.tsx
View File

@@ -17,6 +17,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation: ReturnType<typeof vi.fn>;
updateAssets: ReturnType<typeof vi.fn>;
updateDocument: ReturnType<typeof vi.fn>;
updateSelection: ReturnType<typeof vi.fn>;
setRenderEnabled: ReturnType<typeof vi.fn>;
setGridVisible: ReturnType<typeof vi.fn>;
setViewMode: ReturnType<typeof vi.fn>;
@@ -45,6 +46,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
updateSimulation = vi.fn();
updateAssets = vi.fn();
updateDocument = vi.fn();
updateSelection = vi.fn();
setRenderEnabled = vi.fn();
setGridVisible = vi.fn();
setViewMode = vi.fn();