giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor: Improve readability in ThirdPersonNavigationController unit tests

Browse Source
This commit is contained in:
Victor Giers
2026-04-25 19:16:01 +02:00
parent 8c9ab0662c
commit 5cb2ce4a61
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/unit/third-person-navigation-controller.test.ts
View File

@@ -276,7 +276,10 @@ describe("ThirdPersonNavigationController", () => {
controller.update(0); controller.update(0);
expect(latestDesiredCameraPosition).not.toBeNull(); expect(latestDesiredCameraPosition).not.toBeNull();
expect(latestDesiredCameraPosition?.y ?? 0).toBeLessThan(floorHeight); const desiredCameraPosition =
latestDesiredCameraPosition ?? { x: 0, y: 0, z: 0 };
expect(desiredCameraPosition.y).toBeLessThan(floorHeight);
expect(context.camera.position.y).toBeCloseTo(floorHeight); expect(context.camera.position.y).toBeCloseTo(floorHeight);
expect( expect(
distanceBetween( distanceBetween(
@@ -289,7 +292,7 @@ describe("ThirdPersonNavigationController", () => {
) )
).toBeLessThan( ).toBeLessThan(
distanceBetween( distanceBetween(
latestDesiredCameraPosition ?? { x: 0, y: 0, z: 0 }, desiredCameraPosition,
latestPivot ?? { x: 0, y: 0, z: 0 } latestPivot ?? { x: 0, y: 0, z: 0 }
) )
); );