From 5cb2ce4a6122c8ea1951463f88ccf1af883d64ad Mon Sep 17 00:00:00 2001 From: Victor Giers Date: Sat, 25 Apr 2026 19:16:01 +0200 Subject: [PATCH] Refactor: Improve readability in ThirdPersonNavigationController unit tests --- tests/unit/third-person-navigation-controller.test.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/unit/third-person-navigation-controller.test.ts b/tests/unit/third-person-navigation-controller.test.ts index 894809d7..467d421f 100644 --- a/tests/unit/third-person-navigation-controller.test.ts +++ b/tests/unit/third-person-navigation-controller.test.ts @@ -276,7 +276,10 @@ describe("ThirdPersonNavigationController", () => { controller.update(0); expect(latestDesiredCameraPosition).not.toBeNull(); - expect(latestDesiredCameraPosition?.y ?? 0).toBeLessThan(floorHeight); + const desiredCameraPosition = + latestDesiredCameraPosition ?? { x: 0, y: 0, z: 0 }; + + expect(desiredCameraPosition.y).toBeLessThan(floorHeight); expect(context.camera.position.y).toBeCloseTo(floorHeight); expect( distanceBetween( @@ -289,7 +292,7 @@ describe("ThirdPersonNavigationController", () => { ) ).toBeLessThan( distanceBetween( - latestDesiredCameraPosition ?? { x: 0, y: 0, z: 0 }, + desiredCameraPosition, latestPivot ?? { x: 0, y: 0, z: 0 } ) );