giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor transform-session.ts to use local target variables for clarity and consistency

Browse Source
This commit is contained in:
Victor Giers
2026-04-15 15:00:34 +02:00
parent a9806e8366
commit f46039804f
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/core/transform-session.ts
View File

@@ -1033,12 +1033,13 @@ export function doesTransformSessionChangeTarget(
)) ))
); );
case "brushes": case "brushes":
const brushesTarget = session.target;
return ( return (
session.preview.kind === "brushes" && session.preview.kind === "brushes" &&
(!areVec3Equal(session.preview.pivot, session.target.initialPivot) || (!areVec3Equal(session.preview.pivot, brushesTarget.initialPivot) ||
session.preview.items.length !== session.target.items.length || session.preview.items.length !== brushesTarget.items.length ||
session.preview.items.some((item, index) => { session.preview.items.some((item, index) => {
const targetItem = session.target.items[index]; const targetItem = brushesTarget.items[index];
return ( return (
item.brushId !== targetItem.brushId || item.brushId !== targetItem.brushId ||
@@ -1066,12 +1067,16 @@ export function doesTransformSessionChangeTarget(
!areVec3Equal(session.preview.scale, session.target.initialScale)) !areVec3Equal(session.preview.scale, session.target.initialScale))
); );
case "modelInstances": case "modelInstances":
const modelInstancesTarget = session.target;
return ( return (
session.preview.kind === "modelInstances" && session.preview.kind === "modelInstances" &&
(!areVec3Equal(session.preview.pivot, session.target.initialPivot) || (!areVec3Equal(
session.preview.items.length !== session.target.items.length || session.preview.pivot,
modelInstancesTarget.initialPivot
) ||
session.preview.items.length !== modelInstancesTarget.items.length ||
session.preview.items.some((item, index) => { session.preview.items.some((item, index) => {
const targetItem = session.target.items[index]; const targetItem = modelInstancesTarget.items[index];
return ( return (
item.modelInstanceId !== targetItem.modelInstanceId || item.modelInstanceId !== targetItem.modelInstanceId ||
@@ -1105,12 +1110,13 @@ export function doesTransformSessionChangeTarget(
)) ))
); );
case "entities": case "entities":
const entitiesTarget = session.target;
return ( return (
session.preview.kind === "entities" && session.preview.kind === "entities" &&
(!areVec3Equal(session.preview.pivot, session.target.initialPivot) || (!areVec3Equal(session.preview.pivot, entitiesTarget.initialPivot) ||
session.preview.items.length !== session.target.items.length || session.preview.items.length !== entitiesTarget.items.length ||
session.preview.items.some((item, index) => { session.preview.items.some((item, index) => {
const targetItem = session.target.items[index]; const targetItem = entitiesTarget.items[index];
return ( return (
item.entityId !== targetItem.entityId || item.entityId !== targetItem.entityId ||