giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update terrain layer validation to enforce minimum and maximum layer counts

Browse Source
This commit is contained in:
Victor Giers
2026-05-13 00:42:39 +02:00
parent fa2183f04e
commit e32023595f
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/document/terrains.ts
View File

@@ -84,6 +84,9 @@ export const DEFAULT_TERRAIN_SAMPLE_COUNT_Z = 9;
export const DEFAULT_TERRAIN_CELL_SIZE = 1; export const DEFAULT_TERRAIN_CELL_SIZE = 1;
export const DEFAULT_TERRAIN_HEIGHT = 0; export const DEFAULT_TERRAIN_HEIGHT = 0;
export const TERRAIN_LAYER_COUNT = 4; export const TERRAIN_LAYER_COUNT = 4;
export const MIN_TERRAIN_LAYER_COUNT = 1;
export const MAX_TERRAIN_LAYER_COUNT = 8;
export const TERRAIN_SHADER_LAYER_COUNT = 8;
export const DEFAULT_TERRAIN_LAYER_MATERIAL_IDS = [ export const DEFAULT_TERRAIN_LAYER_MATERIAL_IDS = [
"patchy_grass_ground_250x250", "patchy_grass_ground_250x250",
"patchy_weedy_dirt_ground_300x300", "patchy_weedy_dirt_ground_300x300",
@@ -190,7 +193,7 @@ function normalizeTerrainFoliageLayerId(value: string, label: string): string {
} }
export function getTerrainLayerLabel(layerIndex: number): string { export function getTerrainLayerLabel(layerIndex: number): string {
if (!Number.isInteger(layerIndex) || layerIndex < 0 || layerIndex >= TERRAIN_LAYER_COUNT) { if (!Number.isInteger(layerIndex) || layerIndex < 0) {
throw new Error(`Terrain layer index ${layerIndex} is out of range.`); throw new Error(`Terrain layer index ${layerIndex} is out of range.`);
} }
@@ -221,9 +224,13 @@ function normalizeTerrainLayers(
return createDefaultTerrainLayers(); return createDefaultTerrainLayers();
} }
if (layers.length !== TERRAIN_LAYER_COUNT) { if (
!Number.isInteger(layers.length) ||
layers.length < MIN_TERRAIN_LAYER_COUNT ||
layers.length > MAX_TERRAIN_LAYER_COUNT
) {
throw new Error( throw new Error(
`Terrain layers must contain exactly ${TERRAIN_LAYER_COUNT} layer slots.` `Terrain layers must contain between ${MIN_TERRAIN_LAYER_COUNT} and ${MAX_TERRAIN_LAYER_COUNT} layer slots.`
); );
} }