giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Include optional name in various entity readers

Browse Source
This commit is contained in:
Victor Giers
2026-04-03 01:03:06 +02:00
parent c90c2ba5ad
commit dd5482551e
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/document/migrate-scene-document.ts
View File

@@ -824,6 +824,7 @@ function readPointLightEntity(value: unknown, label: string): EntityInstance {
const kind = expectLiteralString(value.kind, "pointLight", `${label}.kind`); const kind = expectLiteralString(value.kind, "pointLight", `${label}.kind`);
const entity = createPointLightEntity({ const entity = createPointLightEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
colorHex: expectHexColor(value.colorHex, `${label}.colorHex`), colorHex: expectHexColor(value.colorHex, `${label}.colorHex`),
intensity: expectNonNegativeFiniteNumber(value.intensity, `${label}.intensity`), intensity: expectNonNegativeFiniteNumber(value.intensity, `${label}.intensity`),
@@ -845,6 +846,7 @@ function readSpotLightEntity(value: unknown, label: string): EntityInstance {
const kind = expectLiteralString(value.kind, "spotLight", `${label}.kind`); const kind = expectLiteralString(value.kind, "spotLight", `${label}.kind`);
const entity = createSpotLightEntity({ const entity = createSpotLightEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
direction: readVec3(value.direction, `${label}.direction`), direction: readVec3(value.direction, `${label}.direction`),
colorHex: expectHexColor(value.colorHex, `${label}.colorHex`), colorHex: expectHexColor(value.colorHex, `${label}.colorHex`),
@@ -868,6 +870,7 @@ function readPlayerStartEntity(value: unknown, label: string): EntityInstance {
const kind = expectLiteralString(value.kind, "playerStart", `${label}.kind`); const kind = expectLiteralString(value.kind, "playerStart", `${label}.kind`);
const entity = createPlayerStartEntity({ const entity = createPlayerStartEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
yawDegrees: expectFiniteNumber(value.yawDegrees, `${label}.yawDegrees`) yawDegrees: expectFiniteNumber(value.yawDegrees, `${label}.yawDegrees`)
}); });
@@ -887,6 +890,7 @@ function readSoundEmitterEntity(value: unknown, label: string): EntityInstance {
const kind = expectLiteralString(value.kind, "soundEmitter", `${label}.kind`); const kind = expectLiteralString(value.kind, "soundEmitter", `${label}.kind`);
const entity = createSoundEmitterEntity({ const entity = createSoundEmitterEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
audioAssetId: audioAssetId:
value.audioAssetId === undefined || value.audioAssetId === null value.audioAssetId === undefined || value.audioAssetId === null
@@ -915,6 +919,7 @@ function readLegacySoundEmitterEntity(value: unknown, label: string): EntityInst
const radius = expectPositiveFiniteNumber(value.radius, `${label}.radius`); const radius = expectPositiveFiniteNumber(value.radius, `${label}.radius`);
const entity = createSoundEmitterEntity({ const entity = createSoundEmitterEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
refDistance: radius, refDistance: radius,
maxDistance: radius, maxDistance: radius,
@@ -944,6 +949,7 @@ function readTriggerVolumeEntity(value: unknown, label: string): EntityInstance
const entity = createTriggerVolumeEntity({ const entity = createTriggerVolumeEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
size, size,
triggerOnEnter: expectBoolean(value.triggerOnEnter, `${label}.triggerOnEnter`), triggerOnEnter: expectBoolean(value.triggerOnEnter, `${label}.triggerOnEnter`),
@@ -965,6 +971,7 @@ function readTeleportTargetEntity(value: unknown, label: string): EntityInstance
const kind = expectLiteralString(value.kind, "teleportTarget", `${label}.kind`); const kind = expectLiteralString(value.kind, "teleportTarget", `${label}.kind`);
const entity = createTeleportTargetEntity({ const entity = createTeleportTargetEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
yawDegrees: expectFiniteNumber(value.yawDegrees, `${label}.yawDegrees`) yawDegrees: expectFiniteNumber(value.yawDegrees, `${label}.yawDegrees`)
}); });
@@ -984,6 +991,7 @@ function readInteractableEntity(value: unknown, label: string): EntityInstance {
const kind = expectLiteralString(value.kind, "interactable", `${label}.kind`); const kind = expectLiteralString(value.kind, "interactable", `${label}.kind`);
const entity = createInteractableEntity({ const entity = createInteractableEntity({
id: expectString(value.id, `${label}.id`), id: expectString(value.id, `${label}.id`),
name: readOptionalEntityName(value.name, `${label}.name`),
position: readVec3(value.position, `${label}.position`), position: readVec3(value.position, `${label}.position`),
radius: expectPositiveFiniteNumber(value.radius, `${label}.radius`), radius: expectPositiveFiniteNumber(value.radius, `${label}.radius`),
prompt: expectString(value.prompt, `${label}.prompt`), prompt: expectString(value.prompt, `${label}.prompt`),