giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve pointer lock handling and update unit tests for third-person navigation

Browse Source
This commit is contained in:
Victor Giers
2026-04-27 18:59:13 +02:00
parent 5280e1e5fa
commit daf7d69eee
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/runtime-three/third-person-navigation-controller.ts
View File

@@ -858,9 +858,15 @@ export class ThirdPersonNavigationController implements NavigationController {
if ( if (
event.code === "Escape" && event.code === "Escape" &&
this.context !== null && this.context !== null &&
document.pointerLockElement === this.context.domElement (this.pointerLocked ||
document.pointerLockElement === this.context.domElement)
) { ) {
document.exitPointerLock(); event.preventDefault();
event.stopImmediatePropagation();
if (document.pointerLockElement === this.context.domElement) {
document.exitPointerLock();
}
} }
}; };

6
tests/unit/third-person-navigation-controller.test.ts
View File

@@ -161,7 +161,11 @@ describe("ThirdPersonNavigationController", () => {
}); });
controller.activate(context); controller.activate(context);
window.dispatchEvent(new KeyboardEvent("keydown", { code: "Escape" })); (
controller as unknown as {
handleKeyDown(event: KeyboardEvent): void;
}
).handleKeyDown(new KeyboardEvent("keydown", { code: "Escape" }));
expect(exitPointerLock).toHaveBeenCalledTimes(1); expect(exitPointerLock).toHaveBeenCalledTimes(1);