giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update e2e tests to include additional viewport checks and helper function

Browse Source
This commit is contained in:
Victor Giers
2026-04-02 22:39:51 +02:00
parent e6f4672b3e
commit b6af0f8d25
2 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/e2e/app-smoke.e2e.ts
View File

@@ -18,6 +18,9 @@ test("app boots and shows the viewport shell", async ({ page }) => {
await expect(page.getByTestId("toolbar-scene-name")).toHaveValue("Untitled Scene"); await expect(page.getByTestId("toolbar-scene-name")).toHaveValue("Untitled Scene");
await expect(page.getByTestId("viewport-shell")).toBeVisible(); await expect(page.getByTestId("viewport-shell")).toBeVisible();
await expect(page.getByTestId("viewport-panel-topLeft")).toBeVisible();
await expect(page.getByTestId("viewport-layout-single")).toBeVisible();
await expect(page.getByTestId("viewport-layout-quad")).toBeVisible();
await expect(page.getByTestId("enter-run-mode")).toBeVisible(); await expect(page.getByTestId("enter-run-mode")).toBeVisible();
await expect(page.getByTestId("material-button-starter-amber-grid")).toBeVisible(); await expect(page.getByTestId("material-button-starter-amber-grid")).toBeVisible();

24
tests/e2e/box-brush-authoring.e2e.ts
View File

@@ -1,5 +1,7 @@
import { expect, test } from "@playwright/test"; import { expect, test } from "@playwright/test";
import { clickViewport } from "./viewport-test-helpers";
test("user can create a box brush and keep it through a draft reload", async ({ page }) => { test("user can create a box brush and keep it through a draft reload", async ({ page }) => {
const pageErrors: string[] = []; const pageErrors: string[] = [];
const consoleErrors: string[] = []; const consoleErrors: string[] = [];
@@ -21,12 +23,7 @@ test("user can create a box brush and keep it through a draft reload", async ({
await page.reload(); await page.reload();
await page.getByRole("button", { name: "Box Create" }).click(); await page.getByRole("button", { name: "Box Create" }).click();
const viewportCanvas = page.locator('[data-testid="viewport-shell"] canvas'); await clickViewport(page);
if ((await viewportCanvas.count()) > 0) {
await viewportCanvas.click();
} else {
await page.getByTestId("viewport-fallback-create-box").click();
}
await expect(page.getByRole("button", { name: /Box Brush 1/ })).toBeVisible(); await expect(page.getByRole("button", { name: /Box Brush 1/ })).toBeVisible();
await expect(page.getByText("1 brush selected (Box Brush 1)")).toBeVisible(); await expect(page.getByText("1 brush selected (Box Brush 1)")).toBeVisible();
await expect(page.getByTestId("apply-brush-position")).toHaveCount(0); await expect(page.getByTestId("apply-brush-position")).toHaveCount(0);
@@ -46,7 +43,7 @@ test("user can create a box brush and keep it through a draft reload", async ({
await page.getByRole("button", { name: /Entry Room/ }).click(); await page.getByRole("button", { name: /Entry Room/ }).click();
await expect(page.getByTestId("brush-center-y")).toHaveValue("2"); await expect(page.getByTestId("brush-center-y")).toHaveValue("2");
await expect(page.getByTestId("brush-size-z")).toHaveValue("4"); await expect(page.getByTestId("brush-size-z")).toHaveValue("4");
await expect(page.getByTestId("viewport-overlay")).toBeVisible(); await expect(page.getByTestId("viewport-overlay-topLeft")).toBeVisible();
expect(pageErrors).toEqual([]); expect(pageErrors).toEqual([]);
expect(consoleErrors).toEqual([]); expect(consoleErrors).toEqual([]);
@@ -59,19 +56,10 @@ test("switching selection while a transform input is active does not overwrite t
}, "webeditor3d.scene-document-draft"); }, "webeditor3d.scene-document-draft");
await page.reload(); await page.reload();
const viewportCanvas = page.locator('[data-testid="viewport-shell"] canvas');
await page.getByRole("button", { name: "Box Create" }).click(); await page.getByRole("button", { name: "Box Create" }).click();
if ((await viewportCanvas.count()) > 0) { await clickViewport(page);
await viewportCanvas.click();
} else {
await page.getByTestId("viewport-fallback-create-box").click();
}
await page.getByRole("button", { name: "Box Create" }).click(); await page.getByRole("button", { name: "Box Create" }).click();
if ((await viewportCanvas.count()) > 0) { await clickViewport(page);
await viewportCanvas.click();
} else {
await page.getByTestId("viewport-fallback-create-box").click();
}
const outlinerButtons = page.getByTestId("outliner-brush-list").getByRole("button"); const outlinerButtons = page.getByTestId("outliner-brush-list").getByRole("button");