giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor FirstPersonNavigationController to use local context and improve null safety in mouse movement handling

Browse Source
This commit is contained in:
Victor Giers
2026-04-27 17:29:19 +02:00
parent 4c98e2d6a6
commit 7c39fc85f0
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/runtime-three/first-person-navigation-controller.ts
View File

@@ -510,23 +510,25 @@ export class FirstPersonNavigationController implements NavigationController {
}; };
private handleMouseMove = (event: MouseEvent) => { private handleMouseMove = (event: MouseEvent) => {
const context = this.context;
if ( if (
!this.pointerLocked || !this.pointerLocked ||
this.context?.isInputSuspended() === true || context?.isInputSuspended() === true ||
this.context?.isCameraDrivenExternally() === true context?.isCameraDrivenExternally() === true ||
context === null
) { ) {
return; return;
} }
const horizontalMouseLookSign = const horizontalMouseLookSign =
this.context.getRuntimeScene().playerStart?.invertMouseCameraHorizontal === context.getRuntimeScene().playerStart?.invertMouseCameraHorizontal === true
true
? -1 ? -1
: 1; : 1;
const horizontalMovement = event.movementX * horizontalMouseLookSign; const horizontalMovement = event.movementX * horizontalMouseLookSign;
const targetLookResult = const targetLookResult =
this.context?.handleRuntimeTargetLookInput?.({ context.handleRuntimeTargetLookInput?.({
horizontal: horizontalMovement, horizontal: horizontalMovement,
vertical: -event.movementY vertical: -event.movementY
}) ?? null; }) ?? null;