giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve camera state comparison using epsilon for float precision

Browse Source
This commit is contained in:
Victor Giers
2026-04-28 17:43:21 +02:00
parent 985f83ea32
commit 71ae447b3c
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/viewport-three/viewport-layout.ts
View File

@@ -114,15 +114,24 @@ export function cloneViewportPanelCameraState(cameraState: ViewportPanelCameraSt
}; };
} }
const VIEWPORT_CAMERA_STATE_EPSILON = 1e-6;
function areCameraNumbersEqual(a: number, b: number): boolean {
return Math.abs(a - b) <= VIEWPORT_CAMERA_STATE_EPSILON;
}
export function areViewportPanelCameraStatesEqual(a: ViewportPanelCameraState, b: ViewportPanelCameraState): boolean { export function areViewportPanelCameraStatesEqual(a: ViewportPanelCameraState, b: ViewportPanelCameraState): boolean {
return ( return (
a.target.x === b.target.x && areCameraNumbersEqual(a.target.x, b.target.x) &&
a.target.y === b.target.y && areCameraNumbersEqual(a.target.y, b.target.y) &&
a.target.z === b.target.z && areCameraNumbersEqual(a.target.z, b.target.z) &&
a.perspectiveOrbit.radius === b.perspectiveOrbit.radius && areCameraNumbersEqual(
a.perspectiveOrbit.theta === b.perspectiveOrbit.theta && a.perspectiveOrbit.radius,
a.perspectiveOrbit.phi === b.perspectiveOrbit.phi && b.perspectiveOrbit.radius
a.orthographicZoom === b.orthographicZoom ) &&
areCameraNumbersEqual(a.perspectiveOrbit.theta, b.perspectiveOrbit.theta) &&
areCameraNumbersEqual(a.perspectiveOrbit.phi, b.perspectiveOrbit.phi) &&
areCameraNumbersEqual(a.orthographicZoom, b.orthographicZoom)
); );
} }