giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update e2e tests to specify model instance positions and use new viewport placement helper

Browse Source
This commit is contained in:
Victor Giers
2026-04-03 00:08:35 +02:00
parent d4d6711e65
commit 5927304628
4 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/e2e/import-draco-model-asset.e2e.ts
View File

@@ -61,7 +61,10 @@ test("imports a draco-compressed glb asset, places an instance, and survives rel
throw new Error("Placed model instance is missing from the document snapshot."); throw new Error("Placed model instance is missing from the document snapshot.");
} }
expect(Math.abs(selectedModelInstance.position.x) > 0 || Math.abs(selectedModelInstance.position.z) > 0).toBe(true); expect(selectedModelInstance.position).toMatchObject({
x: 84,
z: -88
});
await page.getByRole("button", { name: "Save Draft" }).click(); await page.getByRole("button", { name: "Save Draft" }).click();
await expect(page.getByTestId("status-message")).toContainText("Local draft saved."); await expect(page.getByTestId("status-message")).toContainText("Local draft saved.");

5
tests/e2e/import-external-model-asset.e2e.ts
View File

@@ -60,7 +60,10 @@ test("imports a gltf asset with external resources and places an instance", asyn
throw new Error("Placed model instance is missing from the document snapshot."); throw new Error("Placed model instance is missing from the document snapshot.");
} }
expect(Math.abs(selectedModelInstance.position.x) > 0 || Math.abs(selectedModelInstance.position.z) > 0).toBe(true); expect(selectedModelInstance.position).toMatchObject({
x: 88,
z: -84
});
expect(pageErrors).toEqual([]); expect(pageErrors).toEqual([]);
expect(consoleErrors).toEqual([]); expect(consoleErrors).toEqual([]);

5
tests/e2e/import-model-asset.e2e.ts
View File

@@ -62,7 +62,10 @@ test("imports a model asset, places an instance, and survives reload", async ({
throw new Error("Placed model instance is missing from the document snapshot."); throw new Error("Placed model instance is missing from the document snapshot.");
} }
expect(Math.abs(selectedModelInstance.position.x) > 0 || Math.abs(selectedModelInstance.position.z) > 0).toBe(true); expect(selectedModelInstance.position).toMatchObject({
x: 92,
z: -76
});
await page.getByRole("button", { name: "Save Draft" }).click(); await page.getByRole("button", { name: "Save Draft" }).click();
await expect(page.getByTestId("status-message")).toContainText("Local draft saved."); await expect(page.getByTestId("status-message")).toContainText("Local draft saved.");

15
tests/e2e/local-lights-and-background.e2e.ts
View File

@@ -2,7 +2,7 @@ import path from "node:path";
import { expect, test } from "@playwright/test"; import { expect, test } from "@playwright/test";
import { getViewportCanvas } from "./viewport-test-helpers"; import { setViewportPlacementPreview } from "./viewport-test-helpers";
const panoramaFixturePath = path.resolve(process.cwd(), "fixtures/assets/skybox-panorama.svg"); const panoramaFixturePath = path.resolve(process.cwd(), "fixtures/assets/skybox-panorama.svg");
@@ -39,10 +39,9 @@ test("local lights and background images persist through editor and runner flows
await page.getByTestId("outliner-add-button").click(); await page.getByTestId("outliner-add-button").click();
await page.getByTestId("add-menu-lights").click(); await page.getByTestId("add-menu-lights").click();
await page.getByTestId("add-menu-point-light").click(); await page.getByTestId("add-menu-point-light").click();
await page.getByTestId("viewport-panel-topLeft").click({ position: { x: 16, y: 16 }, force: true }); await setViewportPlacementPreview(page, "topLeft", { kind: "entity", entityKind: "pointLight", audioAssetId: null }, { x: 12, y: 3, z: -4 });
const viewportCanvas = getViewportCanvas(page); await expect(page.getByTestId("viewport-snap-preview-topLeft")).toBeVisible();
await viewportCanvas.hover({ position: { x: 172, y: 116 }, force: true }); await page.getByTestId("viewport-fallback-place-topLeft").click();
await viewportCanvas.click({ position: { x: 172, y: 116 }, force: true });
await expect(page.getByTestId("point-light-distance")).toHaveValue("8"); await expect(page.getByTestId("point-light-distance")).toHaveValue("8");
await page.getByTestId("point-light-distance").fill("12"); await page.getByTestId("point-light-distance").fill("12");
await page.getByTestId("point-light-distance").press("Tab"); await page.getByTestId("point-light-distance").press("Tab");
@@ -50,9 +49,9 @@ test("local lights and background images persist through editor and runner flows
await page.getByTestId("outliner-add-button").click(); await page.getByTestId("outliner-add-button").click();
await page.getByTestId("add-menu-lights").click(); await page.getByTestId("add-menu-lights").click();
await page.getByTestId("add-menu-spot-light").click(); await page.getByTestId("add-menu-spot-light").click();
await page.getByTestId("viewport-panel-topLeft").click({ position: { x: 16, y: 16 }, force: true }); await setViewportPlacementPreview(page, "topLeft", { kind: "entity", entityKind: "spotLight", audioAssetId: null }, { x: -10, y: 4, z: 6 });
await viewportCanvas.hover({ position: { x: 240, y: 132 }, force: true }); await expect(page.getByTestId("viewport-snap-preview-topLeft")).toBeVisible();
await viewportCanvas.click({ position: { x: 240, y: 132 }, force: true }); await page.getByTestId("viewport-fallback-place-topLeft").click();
await expect(page.getByTestId("spot-light-angle")).toHaveValue("35"); await expect(page.getByTestId("spot-light-angle")).toHaveValue("35");
await page.getByTestId("spot-light-angle").fill("48"); await page.getByTestId("spot-light-angle").fill("48");
await page.getByTestId("spot-light-angle").press("Tab"); await page.getByTestId("spot-light-angle").press("Tab");