Enhance unit tests for RuntimeHost, improving coverage for Escape key handling and pointer lock state transitions
This commit is contained in:
@@ -3889,7 +3889,7 @@ describe("RuntimeHost", () => {
|
|||||||
host.dispose();
|
host.dispose();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("does not consume Escape for clear-target while pointer lock is active", () => {
|
it("reserves Escape for pointer-lock release before gameplay bindings", () => {
|
||||||
const host = new RuntimeHost({
|
const host = new RuntimeHost({
|
||||||
enableRendering: false
|
enableRendering: false
|
||||||
});
|
});
|
||||||
@@ -3897,12 +3897,18 @@ describe("RuntimeHost", () => {
|
|||||||
domElement: HTMLCanvasElement;
|
domElement: HTMLCanvasElement;
|
||||||
runtimeScene: unknown;
|
runtimeScene: unknown;
|
||||||
sceneReady: boolean;
|
sceneReady: boolean;
|
||||||
|
pressedKeys: Set<string>;
|
||||||
activeRuntimeTargetReference: {
|
activeRuntimeTargetReference: {
|
||||||
kind: "npc" | "interactable";
|
kind: "npc" | "interactable";
|
||||||
entityId: string;
|
entityId: string;
|
||||||
} | null;
|
} | null;
|
||||||
handleRuntimeKeyDown(event: KeyboardEvent): void;
|
handlePointerLockEscapeKeyDown(event: KeyboardEvent): void;
|
||||||
|
updateClearTargetInputState(): void;
|
||||||
};
|
};
|
||||||
|
let pointerLockElement: Element | null = hostInternals.domElement;
|
||||||
|
const exitPointerLock = vi.fn(() => {
|
||||||
|
pointerLockElement = null;
|
||||||
|
});
|
||||||
const escapeEvent = {
|
const escapeEvent = {
|
||||||
code: "Escape",
|
code: "Escape",
|
||||||
defaultPrevented: false,
|
defaultPrevented: false,
|
||||||
@@ -3917,7 +3923,11 @@ describe("RuntimeHost", () => {
|
|||||||
|
|
||||||
Object.defineProperty(document, "pointerLockElement", {
|
Object.defineProperty(document, "pointerLockElement", {
|
||||||
configurable: true,
|
configurable: true,
|
||||||
get: () => hostInternals.domElement
|
get: () => pointerLockElement
|
||||||
|
});
|
||||||
|
Object.defineProperty(document, "exitPointerLock", {
|
||||||
|
configurable: true,
|
||||||
|
value: exitPointerLock
|
||||||
});
|
});
|
||||||
|
|
||||||
hostInternals.runtimeScene = {
|
hostInternals.runtimeScene = {
|
||||||
@@ -3940,14 +3950,17 @@ describe("RuntimeHost", () => {
|
|||||||
entityId: "npc-active"
|
entityId: "npc-active"
|
||||||
};
|
};
|
||||||
|
|
||||||
hostInternals.handleRuntimeKeyDown(escapeEvent);
|
hostInternals.handlePointerLockEscapeKeyDown(escapeEvent);
|
||||||
|
hostInternals.updateClearTargetInputState();
|
||||||
|
|
||||||
expect(hostInternals.activeRuntimeTargetReference).toEqual({
|
expect(hostInternals.activeRuntimeTargetReference).toEqual({
|
||||||
kind: "npc",
|
kind: "npc",
|
||||||
entityId: "npc-active"
|
entityId: "npc-active"
|
||||||
});
|
});
|
||||||
|
expect(hostInternals.pressedKeys.has("Escape")).toBe(false);
|
||||||
|
expect(exitPointerLock).toHaveBeenCalledTimes(1);
|
||||||
expect(escapeEvent.preventDefault).not.toHaveBeenCalled();
|
expect(escapeEvent.preventDefault).not.toHaveBeenCalled();
|
||||||
expect(escapeEvent.stopImmediatePropagation).not.toHaveBeenCalled();
|
expect(escapeEvent.stopImmediatePropagation).toHaveBeenCalledTimes(1);
|
||||||
|
|
||||||
Object.defineProperty(document, "pointerLockElement", {
|
Object.defineProperty(document, "pointerLockElement", {
|
||||||
configurable: true,
|
configurable: true,
|
||||||
@@ -3956,6 +3969,90 @@ describe("RuntimeHost", () => {
|
|||||||
host.dispose();
|
host.dispose();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("reserves Escape immediately after browser pointer-lock release", () => {
|
||||||
|
const host = new RuntimeHost({
|
||||||
|
enableRendering: false
|
||||||
|
});
|
||||||
|
const hostInternals = host as unknown as {
|
||||||
|
controllerContext: {
|
||||||
|
setPlayerControllerTelemetry(telemetry: unknown): void;
|
||||||
|
};
|
||||||
|
runtimeScene: unknown;
|
||||||
|
sceneReady: boolean;
|
||||||
|
activeRuntimeTargetReference: {
|
||||||
|
kind: "npc" | "interactable";
|
||||||
|
entityId: string;
|
||||||
|
} | null;
|
||||||
|
handlePointerLockEscapeKeyDown(event: KeyboardEvent): void;
|
||||||
|
updateClearTargetInputState(): void;
|
||||||
|
};
|
||||||
|
const exitPointerLock = vi.fn();
|
||||||
|
const escapeEvent = {
|
||||||
|
code: "Escape",
|
||||||
|
defaultPrevented: false,
|
||||||
|
repeat: false,
|
||||||
|
altKey: false,
|
||||||
|
ctrlKey: false,
|
||||||
|
metaKey: false,
|
||||||
|
target: null,
|
||||||
|
preventDefault: vi.fn(),
|
||||||
|
stopImmediatePropagation: vi.fn()
|
||||||
|
} as unknown as KeyboardEvent;
|
||||||
|
|
||||||
|
Object.defineProperty(document, "pointerLockElement", {
|
||||||
|
configurable: true,
|
||||||
|
get: () => null
|
||||||
|
});
|
||||||
|
Object.defineProperty(document, "exitPointerLock", {
|
||||||
|
configurable: true,
|
||||||
|
value: exitPointerLock
|
||||||
|
});
|
||||||
|
|
||||||
|
hostInternals.runtimeScene = {
|
||||||
|
playerInputBindings: {
|
||||||
|
keyboard: {
|
||||||
|
clearTarget: "Escape",
|
||||||
|
pauseTime: "KeyP"
|
||||||
|
}
|
||||||
|
},
|
||||||
|
entities: {
|
||||||
|
cameraRigs: [],
|
||||||
|
interactables: [],
|
||||||
|
npcs: []
|
||||||
|
},
|
||||||
|
interactionLinks: []
|
||||||
|
} as never;
|
||||||
|
hostInternals.sceneReady = true;
|
||||||
|
hostInternals.activeRuntimeTargetReference = {
|
||||||
|
kind: "npc",
|
||||||
|
entityId: "npc-active"
|
||||||
|
};
|
||||||
|
hostInternals.controllerContext.setPlayerControllerTelemetry({
|
||||||
|
pointerLocked: true,
|
||||||
|
hooks: {
|
||||||
|
audio: null
|
||||||
|
}
|
||||||
|
});
|
||||||
|
hostInternals.controllerContext.setPlayerControllerTelemetry({
|
||||||
|
pointerLocked: false,
|
||||||
|
hooks: {
|
||||||
|
audio: null
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
hostInternals.handlePointerLockEscapeKeyDown(escapeEvent);
|
||||||
|
hostInternals.updateClearTargetInputState();
|
||||||
|
|
||||||
|
expect(hostInternals.activeRuntimeTargetReference).toEqual({
|
||||||
|
kind: "npc",
|
||||||
|
entityId: "npc-active"
|
||||||
|
});
|
||||||
|
expect(exitPointerLock).not.toHaveBeenCalled();
|
||||||
|
expect(escapeEvent.preventDefault).not.toHaveBeenCalled();
|
||||||
|
expect(escapeEvent.stopImmediatePropagation).toHaveBeenCalledTimes(1);
|
||||||
|
host.dispose();
|
||||||
|
});
|
||||||
|
|
||||||
it("switches an active target once from directional screen-space look input", () => {
|
it("switches an active target once from directional screen-space look input", () => {
|
||||||
const host = new RuntimeHost({
|
const host = new RuntimeHost({
|
||||||
enableRendering: false
|
enableRendering: false
|
||||||
|
|||||||
Reference in New Issue
Block a user