Feature: Implement and integrate transform preview change handling

src/app/App.tsx

@@ -4601,7 +4601,13 @@ export function App({ store, initialStatusMessage }: AppProps) {
 
         if (event.key === "Enter") {
           event.preventDefault();
-          commitTransformSession(transformSession);
+          const latestTransformSession =
+            latestActiveTransformSessionRef.current;
+          commitTransformSession(
+            latestTransformSession?.id === transformSession.id
+              ? latestTransformSession
+              : transformSession
+          );
           return;
         }
 
@@ -14239,8 +14245,16 @@ export function App({ store, initialStatusMessage }: AppProps) {
                   onWhiteboxSnapStepDraftChange={setWhiteboxSnapStepDraft}
                   onWhiteboxSnapStepBlur={handleWhiteboxSnapStepBlur}
                   onTransformSessionChange={(nextTransformSession) => {
+                    latestActiveTransformSessionRef.current =
+                      nextTransformSession.kind === "active"
+                        ? nextTransformSession
+                        : null;
                     store.setTransformSession(nextTransformSession);
                   }}
+                  onTransformPreviewChange={(nextTransformSession) => {
+                    latestActiveTransformSessionRef.current =
+                      nextTransformSession;
+                  }}
                   onTransformCommit={commitTransformSession}
                   onTransformCancel={() => cancelTransformSession()}
                   onSelectionChange={(selection) =>

src/viewport-three/ViewportCanvas.tsx

@@ -73,7 +73,7 @@ interface ViewportCanvasProps {
   onCameraStateChange(cameraState: ViewportPanelCameraState): void;
   onToolPreviewChange(toolPreview: ViewportToolPreview): void;
   onTransformSessionChange(transformSession: TransformSessionState): void;
-  onTransformPreviewChange(transformSession: ActiveTransformSession): void;
+  onTransformPreviewChange?(transformSession: ActiveTransformSession): void;
   onTransformCommit(transformSession: ActiveTransformSession): void;
   onTransformCancel(): void;
 }
@@ -110,7 +110,7 @@ export function ViewportCanvas({
   onCameraStateChange,
   onToolPreviewChange,
   onTransformSessionChange,
-  onTransformPreviewChange,
+  onTransformPreviewChange = () => undefined,
   onTransformCommit,
   onTransformCancel
 }: ViewportCanvasProps) {

tests/unit/app-project-persistence.integration.test.tsx

@@ -22,6 +22,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
     setWhiteboxSelectionMode: ReturnType<typeof vi.fn>;
@@ -51,6 +52,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/app-scene-transition.integration.test.tsx

@@ -31,6 +31,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
     setWhiteboxSelectionMode: ReturnType<typeof vi.fn>;
@@ -60,6 +61,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/interaction-links.inspector.integration.test.tsx

@@ -22,6 +22,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
@@ -52,6 +53,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/light-volume.integration.test.tsx

@@ -31,6 +31,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
     setWhiteboxSelectionMode: ReturnType<typeof vi.fn>;
@@ -61,6 +62,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();
     setWhiteboxSelectionMode = vi.fn();

tests/unit/path-inspector.integration.test.tsx

@@ -21,6 +21,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
@@ -51,6 +52,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/path-point-editing.integration.test.tsx

@@ -32,6 +32,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
@@ -65,6 +66,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/player-start-inspector.integration.test.tsx

@@ -22,6 +22,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
@@ -52,6 +53,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/terrain-foundation.integration.test.tsx

@@ -21,6 +21,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
@@ -51,6 +52,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/transform-foundation.integration.test.tsx

@@ -38,6 +38,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
@@ -71,6 +72,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();

tests/unit/viewport-canvas.test.tsx

@@ -42,6 +42,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCommitHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setTerrainBrushCommitHandler: ReturnType<typeof vi.fn>;
@@ -74,6 +75,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setTerrainBrushCommitHandler = vi.fn();

tests/unit/water-volume.integration.test.tsx

@@ -28,6 +28,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setCreationCommitHandler: ReturnType<typeof vi.fn>;
     setTransformSessionChangeHandler: ReturnType<typeof vi.fn>;
+    setTransformPreviewChangeHandler: ReturnType<typeof vi.fn>;
     setTransformCancelHandler: ReturnType<typeof vi.fn>;
     setWhiteboxHoverLabelChangeHandler: ReturnType<typeof vi.fn>;
     setWhiteboxSelectionMode: ReturnType<typeof vi.fn>;
@@ -57,6 +58,7 @@ const { MockViewportHost, viewportHostInstances } = vi.hoisted(() => {
     setCreationPreviewChangeHandler = vi.fn();
     setCreationCommitHandler = vi.fn();
     setTransformSessionChangeHandler = vi.fn();
+    setTransformPreviewChangeHandler = vi.fn();
     setTransformCommitHandler = vi.fn();
     setTransformCancelHandler = vi.fn();
     setWhiteboxHoverLabelChangeHandler = vi.fn();