giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename render object creation methods in ViewportHost

Browse Source
This commit is contained in:
Victor Giers
2026-03-31 20:06:13 +02:00
parent 45899ecc6a
commit 27d7636a45
1 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/viewport-three/viewport-host.ts
View File

@@ -355,13 +355,13 @@ export class ViewportHost {
switch (entity.kind) { switch (entity.kind) {
case "pointLight": { case "pointLight": {
const renderObjects = this.createPointLightRenderObjects(entity, selected); const renderObjects = this.createPointLightRuntimeObjects(entity);
this.localLightGroup.add(renderObjects.group); this.localLightGroup.add(renderObjects.group);
this.localLightRenderObjects.set(entity.id, renderObjects); this.localLightRenderObjects.set(entity.id, renderObjects);
break; break;
} }
case "spotLight": { case "spotLight": {
const renderObjects = this.createSpotLightRenderObjects(entity, selected); const renderObjects = this.createSpotLightRuntimeObjects(entity);
this.localLightGroup.add(renderObjects.group); this.localLightGroup.add(renderObjects.group);
this.localLightRenderObjects.set(entity.id, renderObjects); this.localLightRenderObjects.set(entity.id, renderObjects);
break; break;
@@ -469,7 +469,7 @@ export class ViewportHost {
group.add(mesh); group.add(mesh);
} }
private createPointLightRenderObjects( private createPointLightGizmoRenderObjects(
entityId: string, entityId: string,
position: Vec3, position: Vec3,
distance: number, distance: number,
@@ -516,7 +516,7 @@ export class ViewportHost {
}; };
} }
private createSpotLightRenderObjects( private createSpotLightGizmoRenderObjects(
entityId: string, entityId: string,
position: Vec3, position: Vec3,
direction: Vec3, direction: Vec3,
@@ -571,7 +571,7 @@ export class ViewportHost {
}; };
} }
private createSpotLightObjects(entity: SpotLightEntity): Group { private createSpotLightRuntimeObjects(entity: SpotLightEntity): LocalLightRenderObjects {
const group = new Group(); const group = new Group();
const light = new SpotLight(entity.colorHex, entity.intensity, entity.distance, (entity.angleDegrees * Math.PI) / 180, 0.18, 1); const light = new SpotLight(entity.colorHex, entity.intensity, entity.distance, (entity.angleDegrees * Math.PI) / 180, 0.18, 1);
const direction = new Vector3(entity.direction.x, entity.direction.y, entity.direction.z).normalize(); const direction = new Vector3(entity.direction.x, entity.direction.y, entity.direction.z).normalize();
@@ -584,10 +584,12 @@ export class ViewportHost {
group.add(light); group.add(light);
group.add(light.target); group.add(light.target);
return group; return {
group
};
} }
private createPointLightObjects(entity: PointLightEntity): Group { private createPointLightRuntimeObjects(entity: PointLightEntity): LocalLightRenderObjects {
const group = new Group(); const group = new Group();
const light = new PointLight(entity.colorHex, entity.intensity, entity.distance); const light = new PointLight(entity.colorHex, entity.intensity, entity.distance);
@@ -595,21 +597,11 @@ export class ViewportHost {
light.position.set(0, 0, 0); light.position.set(0, 0, 0);
group.add(light); group.add(light);
return group;
}
private createPointLightRenderObjectsWrapper(entity: PointLightEntity): LocalLightRenderObjects {
return { return {
group: this.createPointLightObjects(entity) group: this.createPointLightObjects(entity)
}; };
} }
private createSpotLightRenderObjectsWrapper(entity: SpotLightEntity): LocalLightRenderObjects {
return {
group: this.createSpotLightObjects(entity)
};
}
private createPlayerStartRenderObjects(entityId: string, position: Vec3, yawDegrees: number, selected: boolean): EntityRenderObjects { private createPlayerStartRenderObjects(entityId: string, position: Vec3, yawDegrees: number, selected: boolean): EntityRenderObjects {
const markerColor = selected ? PLAYER_START_SELECTED_COLOR : PLAYER_START_COLOR; const markerColor = selected ? PLAYER_START_SELECTED_COLOR : PLAYER_START_COLOR;
const group = new Group(); const group = new Group();