giers10/webeditor3d
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor project-document-json.test.ts by removing Scene Exit entities and updating test cases

Browse Source
This commit is contained in:
Victor Giers
2026-04-15 03:49:35 +02:00
parent ed55b74e01
commit 08d9581407
1 changed files with 14 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/serialization/project-document-json.test.ts
View File

@@ -39,7 +39,6 @@ import {
createNpcEntity, createNpcEntity,
createNpcTimeWindowPresence, createNpcTimeWindowPresence,
createSceneEntryEntity, createSceneEntryEntity,
createSceneExitEntity,
createTriggerVolumeEntity createTriggerVolumeEntity
} from "../../src/entities/entity-instances"; } from "../../src/entities/entity-instances";
import { createProjectScheduleRoutine } from "../../src/scheduler/project-scheduler"; import { createProjectScheduleRoutine } from "../../src/scheduler/project-scheduler";
@@ -389,16 +388,6 @@ describe("project document JSON", () => {
}, },
yawDegrees: 180 yawDegrees: 180
}); });
const mainExit = createSceneExitEntity({
id: "entity-scene-exit-main-hatch",
position: {
x: 0,
y: 1,
z: 3
},
targetSceneId: "scene-cellar",
targetEntryEntityId: cellarEntry.id
});
const document = { const document = {
...createEmptyProjectDocument({ ...createEmptyProjectDocument({
name: "Castle Project", name: "Castle Project",
@@ -421,7 +410,6 @@ describe("project document JSON", () => {
}) })
} }
}; };
document.scenes["scene-main"].entities[mainExit.id] = mainExit;
document.scenes["scene-cellar"].entities[cellarEntry.id] = cellarEntry; document.scenes["scene-cellar"].entities[cellarEntry.id] = cellarEntry;
document.scenes["scene-main"].editorPreferences = { document.scenes["scene-main"].editorPreferences = {
...document.scenes["scene-main"].editorPreferences, ...document.scenes["scene-main"].editorPreferences,
@@ -950,7 +938,7 @@ describe("project document JSON", () => {
); );
}); });
it("migrates v23 project documents without Scene Entry and Scene Exit entities", () => { it("migrates v23 project documents without Scene Entry entities", () => {
const legacyScene = createEmptyProjectScene({ const legacyScene = createEmptyProjectScene({
id: "scene-main", id: "scene-main",
name: "Legacy Entry" name: "Legacy Entry"
@@ -1041,18 +1029,24 @@ describe("project document JSON", () => {
}); });
}); });
it("rejects Scene Exit targets that point at a missing Scene Entry", () => { it("rejects scene transition sequence targets that point at a missing Scene Entry", () => {
const document = createEmptyProjectDocument({ sceneName: "Outside" }); const document = createEmptyProjectDocument({ sceneName: "Outside" });
const targetScene = createEmptyProjectScene({ const targetScene = createEmptyProjectScene({
id: "scene-house", id: "scene-house",
name: "House" name: "House"
}); });
document.scenes[targetScene.id] = targetScene; document.scenes[targetScene.id] = targetScene;
document.scenes["scene-main"].entities["entity-scene-exit-door"] = document.sequences.sequences["sequence-enter-house"] = createProjectSequence({
createSceneExitEntity({ id: "sequence-enter-house",
id: "entity-scene-exit-door", title: "Enter House",
effects: [
{
stepClass: "impulse",
type: "startSceneTransition",
targetSceneId: targetScene.id, targetSceneId: targetScene.id,
targetEntryEntityId: "missing-entry" targetEntryEntityId: "missing-entry"
}
]
}); });
expect(() => expect(() =>