From f533d2f942a6e62d09e7093c3d9aa9350bcba2d8 Mon Sep 17 00:00:00 2001 From: Victor Giers Date: Thu, 2 Apr 2026 20:57:29 +0200 Subject: [PATCH] Remove unnecessary type assertion in optional allowed value reading --- src/document/migrate-scene-document.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/document/migrate-scene-document.ts b/src/document/migrate-scene-document.ts index 434989e0..8c16c9fc 100644 --- a/src/document/migrate-scene-document.ts +++ b/src/document/migrate-scene-document.ts @@ -181,18 +181,16 @@ function readOptionalPositiveInteger(value: unknown, label: string, fallback: nu return integerValue; } -function readOptionalAllowedValue(value: unknown, label: string, fallback: T, guard: (candidate: unknown) => candidate is T): T { +function readOptionalAllowedValue(value: unknown, label: string, fallback: T, guard: (candidate: unknown) => candidate is T): T { if (value === undefined) { return fallback; } - const stringValue = expectString(value, label); - - if (!guard(stringValue)) { + if (!guard(value)) { throw new Error(`${label} must be a supported value.`); } - return stringValue as T; + return value; } function readAdvancedRenderingSettings(value: unknown): AdvancedRenderingSettings {