From ebb4371e189c8868fd319b5681b08093e82be8b3 Mon Sep 17 00:00:00 2001 From: Victor Giers Date: Sun, 5 Apr 2026 04:36:39 +0200 Subject: [PATCH] Update tests to ensure correct duplication without offset --- .../duplicate-selection.command.test.ts | 30 ++++--------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/tests/domain/duplicate-selection.command.test.ts b/tests/domain/duplicate-selection.command.test.ts index 889b1bbc..e7d3aa3a 100644 --- a/tests/domain/duplicate-selection.command.test.ts +++ b/tests/domain/duplicate-selection.command.test.ts @@ -82,11 +82,7 @@ describe("duplicate selection command", () => { const duplicatedBrush = store.getState().document.brushes[selection.ids[0]]; expect(duplicatedBrush).toBeDefined(); - expect(duplicatedBrush.center).toEqual({ - x: sourceBrush.center.x + 1, - y: sourceBrush.center.y, - z: sourceBrush.center.z + 1 - }); + expect(duplicatedBrush.center).toEqual(sourceBrush.center); expect(duplicatedBrush.faces).toEqual(sourceBrush.faces); expect(store.undo()).toBe(true); @@ -150,11 +146,7 @@ describe("duplicate selection command", () => { const duplicatedModelInstance = store.getState().document.modelInstances[duplicatedModelInstanceId]; expect(duplicatedModelInstance.assetId).toBe(sourceModelInstance.assetId); - expect(duplicatedModelInstance.position).toEqual({ - x: sourceModelInstance.position.x + 1, - y: sourceModelInstance.position.y, - z: sourceModelInstance.position.z + 1 - }); + expect(duplicatedModelInstance.position).toEqual(sourceModelInstance.position); expect(store.getState().document.assets[modelAsset.id]).toEqual(modelAsset); expect(Object.keys(store.getState().document.assets)).toHaveLength(1); @@ -213,11 +205,7 @@ describe("duplicate selection command", () => { const duplicatedEntity = store.getState().document.entities[selection.ids[0]]; expect(duplicatedEntity).toBeDefined(); expect(duplicatedEntity.kind).toBe(sourceEntity.kind); - expect(duplicatedEntity.position).toEqual({ - x: sourceEntity.position.x + 1, - y: sourceEntity.position.y, - z: sourceEntity.position.z + 1 - }); + expect(duplicatedEntity.position).toEqual(sourceEntity.position); expect(store.undo()).toBe(true); expect(store.getState().document.entities[sourceEntity.id]).toEqual(sourceEntity); @@ -276,16 +264,8 @@ describe("duplicate selection command", () => { const duplicatedBrushA = store.getState().document.brushes[selection.ids[0]]; const duplicatedBrushB = store.getState().document.brushes[selection.ids[1]]; - expect(duplicatedBrushA.center).toEqual({ - x: sourceBrushA.center.x + 1, - y: sourceBrushA.center.y, - z: sourceBrushA.center.z + 1 - }); - expect(duplicatedBrushB.center).toEqual({ - x: sourceBrushB.center.x + 1, - y: sourceBrushB.center.y, - z: sourceBrushB.center.z + 1 - }); + expect(duplicatedBrushA.center).toEqual(sourceBrushA.center); + expect(duplicatedBrushB.center).toEqual(sourceBrushB.center); expect(store.undo()).toBe(true); expect(Object.keys(store.getState().document.brushes).sort()).toEqual([sourceBrushA.id, sourceBrushB.id]);