From 9edcbe75652674c67c227bf41486a12de418c113 Mon Sep 17 00:00:00 2001
From: Victor Giers <mail@victorgiers.com>
Date: Wed, 15 Apr 2026 07:57:20 +0200
Subject: [PATCH] Add test for hiding target and effect selectors in
 ProjectSequencesPanel for active scene lighting effects

---
 tests/unit/project-sequences-panel.test.tsx | 74 +++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/tests/unit/project-sequences-panel.test.tsx b/tests/unit/project-sequences-panel.test.tsx
index 6b41133d..b5990f63 100644
--- a/tests/unit/project-sequences-panel.test.tsx
+++ b/tests/unit/project-sequences-panel.test.tsx
@@ -2,6 +2,7 @@ import { fireEvent, render, screen } from "@testing-library/react";
 import { describe, expect, it, vi } from "vitest";
 
 import { ProjectSequencesPanel } from "../../src/app/ProjectSequencesPanel";
+import { createActiveSceneControlTargetRef } from "../../src/controls/control-surface";
 import { createProjectSequence } from "../../src/sequencer/project-sequences";
 
 describe("ProjectSequencesPanel", () => {
@@ -291,4 +292,77 @@ describe("ProjectSequencesPanel", () => {
       true
     );
   });
+
+  it("hides target and effect selectors for active scene lighting effects", () => {
+    render(
+      <ProjectSequencesPanel
+        sequences={{
+          sequences: {
+            "sequence-scene": createProjectSequence({
+              id: "sequence-scene",
+              title: "Scene Lighting",
+              effects: [
+                {
+                  stepClass: "held",
+                  type: "controlEffect",
+                  effect: {
+                    type: "setAmbientLightIntensity",
+                    target: createActiveSceneControlTargetRef(),
+                    intensity: 0.4
+                  }
+                }
+              ]
+            })
+          }
+        }}
+        dialogues={{ dialogues: {} }}
+        targetOptions={[
+          {
+            key: "scene:active",
+            target: createActiveSceneControlTargetRef(),
+            label: "Active Scene Lighting",
+            subtitle: "Scene",
+            groupLabel: "Scene Lighting",
+            defaults: {
+              ambientLightIntensity: 1
+            }
+          }
+        ]}
+        teleportTargetOptions={[]}
+        sceneTransitionTargetOptions={[]}
+        visibilityTargetOptions={[]}
+        selectedSequenceId="sequence-scene"
+        onSelectSequence={() => {}}
+        onAddSequence={() => {}}
+        onDeleteSequence={() => {}}
+        onSetSequenceTitle={() => {}}
+        onAddControlEffect={() => {}}
+        onAddDialogueStep={() => {}}
+        onAddTeleportStep={() => {}}
+        onAddSceneTransitionStep={() => {}}
+        onAddVisibilityStep={() => {}}
+        onDeleteStep={() => {}}
+        onSetControlStepTarget={() => {}}
+        onSetControlStepEffectOption={() => {}}
+        onSetControlStepNumericValue={() => {}}
+        onSetControlStepColorValue={() => {}}
+        onSetControlStepAnimationClip={() => {}}
+        onSetControlStepAnimationLoop={() => {}}
+        onSetControlStepPathId={() => {}}
+        onSetControlStepPathSpeed={() => {}}
+        onSetControlStepPathLoop={() => {}}
+        onSetDialogueStepDialogueId={() => {}}
+        onSetTeleportStepTarget={() => {}}
+        onSetSceneTransitionStepTarget={() => {}}
+        onSetVisibilityStepTarget={() => {}}
+        onSetVisibilityStepMode={() => {}}
+      />
+    );
+
+    expect(
+      screen.getByText("This effect applies to the active scene lighting.")
+    ).toBeVisible();
+    expect(screen.queryByLabelText("Target")).toBeNull();
+    expect(screen.queryByLabelText("Effect")).toBeNull();
+  });
 });