From 8358616efc0ac840f3e1a2e9f89fb2500be4e39d Mon Sep 17 00:00:00 2001
From: Victor Giers <mail@victorgiers.com>
Date: Tue, 14 Apr 2026 02:42:21 +0200
Subject: [PATCH] Add test for round-tripping expanded control effect families
 in serialization

---
 .../control-interaction-links.test.ts         | 132 ++++++++++++++++++
 1 file changed, 132 insertions(+)

diff --git a/tests/serialization/control-interaction-links.test.ts b/tests/serialization/control-interaction-links.test.ts
index 879dea64..8d87f0e7 100644
--- a/tests/serialization/control-interaction-links.test.ts
+++ b/tests/serialization/control-interaction-links.test.ts
@@ -70,6 +70,103 @@ describe("control interaction link serialization", () => {
     );
   });
 
+  it("round-trips expanded control effect families", () => {
+    const audioAsset = {
+      id: "asset-audio-main",
+      kind: "audio" as const,
+      sourceName: "loop.ogg",
+      mimeType: "audio/ogg",
+      storageKey: createProjectAssetStorageKey("asset-audio-main"),
+      byteLength: 1024,
+      metadata: {
+        kind: "audio" as const,
+        durationSeconds: 3,
+        channelCount: 2,
+        sampleRateHz: 48000,
+        warnings: []
+      }
+    } satisfies AudioAssetRecord;
+    const modelAsset = {
+      id: "asset-model-main",
+      kind: "model" as const,
+      sourceName: "animated.glb",
+      mimeType: "model/gltf-binary",
+      storageKey: createProjectAssetStorageKey("asset-model-main"),
+      byteLength: 2048,
+      metadata: {
+        kind: "model" as const,
+        format: "glb" as const,
+        sceneName: null,
+        nodeCount: 1,
+        meshCount: 1,
+        materialNames: [],
+        textureNames: [],
+        animationNames: ["Idle"],
+        boundingBox: null,
+        warnings: []
+      }
+    } satisfies ModelAssetRecord;
+    const triggerVolume = createTriggerVolumeEntity({
+      id: "entity-trigger-main"
+    });
+    const pointLight = createPointLightEntity({
+      id: "entity-point-light-main"
+    });
+    const soundEmitter = createSoundEmitterEntity({
+      id: "entity-sound-main",
+      audioAssetId: audioAsset.id
+    });
+    const modelInstance = createModelInstance({
+      id: "model-instance-main",
+      assetId: modelAsset.id
+    });
+    const document = {
+      ...createEmptySceneDocument(),
+      assets: {
+        [audioAsset.id]: audioAsset,
+        [modelAsset.id]: modelAsset
+      },
+      modelInstances: {
+        [modelInstance.id]: modelInstance
+      },
+      entities: {
+        [triggerVolume.id]: triggerVolume,
+        [pointLight.id]: pointLight,
+        [soundEmitter.id]: soundEmitter
+      },
+      interactionLinks: {
+        "link-hide-model": createControlInteractionLink({
+          id: "link-hide-model",
+          sourceEntityId: triggerVolume.id,
+          effect: createSetModelInstanceVisibleControlEffect({
+            target: createModelInstanceControlTargetRef(modelInstance.id),
+            visible: false
+          })
+        }),
+        "link-sound-volume": createControlInteractionLink({
+          id: "link-sound-volume",
+          sourceEntityId: triggerVolume.id,
+          effect: createSetSoundVolumeControlEffect({
+            target: createSoundEmitterControlTargetRef(soundEmitter.id),
+            volume: 0.25
+          })
+        }),
+        "link-ambient-color": createControlInteractionLink({
+          id: "link-ambient-color",
+          sourceEntityId: triggerVolume.id,
+          effect: createSetAmbientLightColorControlEffect({
+            target: createActiveSceneControlTargetRef(),
+            colorHex: "#112233"
+          })
+        })
+      }
+    };
+
+    expect(parseSceneDocumentJson(serializeSceneDocument(document))).toEqual(
+      document
+    );
+  });
+
   it("migrates v44 documents without changing existing interaction links", () => {
     const audioAsset = {
       id: "asset-audio-main",
@@ -120,4 +217,39 @@ describe("control interaction link serialization", () => {
       legacyDocument.interactionLinks
     );
   });
+
+  it("migrates v46 control interaction documents without rewriting effects", () => {
+    const triggerVolume = createTriggerVolumeEntity({
+      id: "entity-trigger-main"
+    });
+    const pointLight = createPointLightEntity({
+      id: "entity-point-light-main"
+    });
+    const legacyDocument = {
+      ...createEmptySceneDocument(),
+      version: PROJECT_SCHEDULER_FOUNDATION_SCENE_DOCUMENT_VERSION,
+      entities: {
+        [triggerVolume.id]: triggerVolume,
+        [pointLight.id]: pointLight
+      },
+      interactionLinks: {
+        "link-light-off": createControlInteractionLink({
+          id: "link-light-off",
+          sourceEntityId: triggerVolume.id,
+          trigger: "enter",
+          effect: createSetLightEnabledControlEffect({
+            target: createLightControlTargetRef("pointLight", pointLight.id),
+            enabled: false
+          })
+        })
+      }
+    };
+
+    const migratedDocument = migrateSceneDocument(legacyDocument);
+
+    expect(migratedDocument.version).toBe(SCENE_DOCUMENT_VERSION);
+    expect(migratedDocument.interactionLinks).toEqual(
+      legacyDocument.interactionLinks
+    );
+  });
 });