From 793b675e7484b3405a3344da9b4192c1c95b63d6 Mon Sep 17 00:00:00 2001 From: Victor Giers Date: Sat, 25 Apr 2026 17:27:00 +0200 Subject: [PATCH] Refactor target look offset calculation using applyTargetLookOffsetDelta --- .../third-person-navigation-controller.ts | 36 ++++--------------- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/src/runtime-three/third-person-navigation-controller.ts b/src/runtime-three/third-person-navigation-controller.ts index f1c6fb34..49280709 100644 --- a/src/runtime-three/third-person-navigation-controller.ts +++ b/src/runtime-three/third-person-navigation-controller.ts @@ -366,21 +366,9 @@ export class ThirdPersonNavigationController implements NavigationController { targetLookResult.switchedTarget !== true && targetLookResult.switchInputHeld !== true ) { - this.targetLookOffsetYawRadians = Math.max( - -TARGET_LOOK_OFFSET_YAW_LIMIT, - Math.min( - TARGET_LOOK_OFFSET_YAW_LIMIT, - this.targetLookOffsetYawRadians - - lookInput.horizontal * TARGET_LOOK_OFFSET_GAMEPAD_SPEED * dt - ) - ); - this.targetLookOffsetPitchRadians = Math.max( - -TARGET_LOOK_OFFSET_PITCH_LIMIT, - Math.min( - TARGET_LOOK_OFFSET_PITCH_LIMIT, - this.targetLookOffsetPitchRadians - - lookInput.vertical * TARGET_LOOK_OFFSET_GAMEPAD_SPEED * dt - ) + this.applyTargetLookOffsetDelta( + -lookInput.horizontal * TARGET_LOOK_OFFSET_GAMEPAD_SPEED * dt, + -lookInput.vertical * TARGET_LOOK_OFFSET_GAMEPAD_SPEED * dt ); } } else if (!cameraDrivenExternally && lookInputActive) { @@ -771,21 +759,9 @@ export class ThirdPersonNavigationController implements NavigationController { targetLookResult.switchedTarget !== true && targetLookResult.switchInputHeld !== true ) { - this.targetLookOffsetYawRadians = Math.max( - -TARGET_LOOK_OFFSET_YAW_LIMIT, - Math.min( - TARGET_LOOK_OFFSET_YAW_LIMIT, - this.targetLookOffsetYawRadians - - deltaX * TARGET_LOOK_OFFSET_POINTER_SENSITIVITY - ) - ); - this.targetLookOffsetPitchRadians = Math.max( - -TARGET_LOOK_OFFSET_PITCH_LIMIT, - Math.min( - TARGET_LOOK_OFFSET_PITCH_LIMIT, - this.targetLookOffsetPitchRadians + - deltaY * TARGET_LOOK_OFFSET_POINTER_SENSITIVITY - ) + this.applyTargetLookOffsetDelta( + -deltaX * TARGET_LOOK_OFFSET_POINTER_SENSITIVITY, + deltaY * TARGET_LOOK_OFFSET_POINTER_SENSITIVITY ); } return;