From 6ecd1e1f3328062bad6815baa7c61f22c90ae660 Mon Sep 17 00:00:00 2001
From: Victor Giers <mail@victorgiers.com>
Date: Wed, 13 May 2026 19:26:51 +0200
Subject: [PATCH] Add comprehensive tests for junction mesh generation and edge
 geometry

---
 .../spline-corridor-junction-mesh.test.ts     | 130 ++++++++++++++++++
 1 file changed, 130 insertions(+)

diff --git a/tests/geometry/spline-corridor-junction-mesh.test.ts b/tests/geometry/spline-corridor-junction-mesh.test.ts
index c6592678..d960a2e6 100644
--- a/tests/geometry/spline-corridor-junction-mesh.test.ts
+++ b/tests/geometry/spline-corridor-junction-mesh.test.ts
@@ -79,6 +79,77 @@ describe("spline corridor junction mesh generation", () => {
     });
   });
 
+  it("supports straight, curved, and hard-corner junction boundary shapes", () => {
+    const pathA = createRoadPath("path-junction-shape-a", [
+      { x: 0, z: 0 },
+      { x: 10, z: 0 }
+    ]);
+    const pathB = createRoadPath("path-junction-shape-b", [
+      { x: 5, z: -5 },
+      { x: 5, z: 5 }
+    ]);
+    const baseJunction = {
+      id: "junction-shape",
+      center: { x: 5, y: 0, z: 0 },
+      radius: 3,
+      connections: [
+        {
+          pathId: pathA.id,
+          progress: 0.5,
+          clipDistance: 2
+        },
+        {
+          pathId: pathB.id,
+          progress: 0.5,
+          clipDistance: 2
+        }
+      ]
+    } as const;
+    const straight = buildSplineCorridorJunctionFootprint({
+      junction: createSplineCorridorJunction({
+        ...baseJunction,
+        shapeMode: "straight"
+      }),
+      paths: [pathA, pathB]
+    });
+    const corner = buildSplineCorridorJunctionFootprint({
+      junction: createSplineCorridorJunction({
+        ...baseJunction,
+        shapeMode: "corner"
+      }),
+      paths: [pathA, pathB]
+    });
+    const curve = buildSplineCorridorJunctionFootprint({
+      junction: createSplineCorridorJunction({
+        ...baseJunction,
+        shapeMode: "curve"
+      }),
+      paths: [pathA, pathB]
+    });
+
+    expect(straight?.points).toHaveLength(8);
+    expect(corner?.points).toHaveLength(12);
+    expect(curve?.points).toHaveLength(28);
+    expect(corner?.points).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({
+          x: expect.closeTo(4, 5),
+          z: expect.closeTo(-1, 5),
+          connectionBoundaryKey: null
+        })
+      ])
+    );
+    expect(curve?.points).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({
+          x: expect.closeTo(3.75, 5),
+          z: expect.closeTo(-1.25, 5),
+          connectionBoundaryKey: null
+        })
+      ])
+    );
+  });
+
   it("builds junction fill geometry from the connection footprint instead of a circle", () => {
     const pathA = createRoadPath("path-junction-mesh-a", [
       { x: 0, z: 0 },
@@ -288,6 +359,65 @@ describe("spline corridor junction mesh generation", () => {
     );
   });
 
+  it("builds perimeter edge rows for curved and hard-corner junction shapes", () => {
+    const pathA = createRoadPath("path-junction-shaped-edge-a", [
+      { x: 0, z: 0 },
+      { x: 10, z: 0 }
+    ]);
+    const pathB = createRoadPath("path-junction-shaped-edge-b", [
+      { x: 5, z: -5 },
+      { x: 5, z: 5 }
+    ]);
+    const baseJunction = {
+      id: "junction-shaped-edge",
+      center: { x: 5, y: 0, z: 0 },
+      radius: 3,
+      edge: {
+        enabled: true,
+        collisionEnabled: false,
+        kind: "curb",
+        width: 0.4,
+        height: 0.2,
+        materialId: null
+      },
+      connections: [
+        {
+          pathId: pathA.id,
+          progress: 0.5,
+          clipDistance: 2
+        },
+        {
+          pathId: pathB.id,
+          progress: 0.5,
+          clipDistance: 2
+        }
+      ]
+    } as const;
+    const cornerMeshData = buildSplineCorridorJunctionEdgeMeshData({
+      junction: createSplineCorridorJunction({
+        ...baseJunction,
+        shapeMode: "corner"
+      }),
+      paths: [pathA, pathB],
+      edge: baseJunction.edge
+    });
+    const curveMeshData = buildSplineCorridorJunctionEdgeMeshData({
+      junction: createSplineCorridorJunction({
+        ...baseJunction,
+        shapeMode: "curve"
+      }),
+      paths: [pathA, pathB],
+      edge: baseJunction.edge
+    });
+
+    expect(cornerMeshData?.footprintPointCount).toBe(12);
+    expect(cornerMeshData?.positions).toHaveLength(12 * 4 * 3);
+    expect(cornerMeshData?.indices).toHaveLength(8 * 3 * 6 + 8 * 2 * 3);
+    expect(curveMeshData?.footprintPointCount).toBe(28);
+    expect(curveMeshData?.positions).toHaveLength(28 * 4 * 3);
+    expect(curveMeshData?.indices).toHaveLength(24 * 3 * 6 + 8 * 2 * 3);
+  });
+
   it("samples full terrain influence inside the connection footprint and falloff outside it", () => {
     const pathA = createRoadPath("path-junction-influence-a", [
       { x: 0, z: 0 },