From 5bd734bf001b318e096de7f2d36c3b6f8e1b81c1 Mon Sep 17 00:00:00 2001 From: Victor Giers Date: Wed, 29 Apr 2026 23:36:15 +0200 Subject: [PATCH] Improve terrain performance tests by resetting long task state and adjusting wait logic --- tests/e2e/terrain-perf.probe.e2e.ts | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/tests/e2e/terrain-perf.probe.e2e.ts b/tests/e2e/terrain-perf.probe.e2e.ts index ecdc7094..13b8f589 100644 --- a/tests/e2e/terrain-perf.probe.e2e.ts +++ b/tests/e2e/terrain-perf.probe.e2e.ts @@ -81,6 +81,15 @@ async function readLongTaskCount(page: Page) { }); } +async function resetLongTasks(page: Page) { + await page.evaluate(() => { + const targetWindow = window as Window & { + __terrainPerfLongTasks?: { duration: number }[]; + }; + targetWindow.__terrainPerfLongTasks = []; + }); +} + function createTerrainScene(size: number, collisionEnabled: boolean) { const document = createEmptySceneDocument({ name: `Terrain ${size} perf` @@ -119,18 +128,11 @@ test("terrain runner and editor zoom perf probe", async ({ page }) => { await installLongTaskObserver(page); for (const size of [100, 320, 640]) { + await resetLongTasks(page); await replaceSceneDocument(page, createTerrainScene(size, true)); await page.getByTestId("enter-run-mode").click(); await page.getByTestId("runner-shell").waitFor({ state: "visible" }); - await page.waitForFunction(() => { - const overlay = document.querySelector( - "[data-testid='runner-loading-overlay']" - ); - - return overlay?.className.includes( - "runner-canvas__loading-overlay--hidden" - ); - }); + await page.waitForTimeout(2_000); const frames = await sampleAnimationFrames(page, 180); const longTaskCount = await readLongTaskCount(page);