From 40541f60f7207f323ef428695690e94258481b28 Mon Sep 17 00:00:00 2001
From: Victor Giers <mail@victorgiers.com>
Date: Wed, 15 Apr 2026 09:52:44 +0200
Subject: [PATCH] Refactor dialogue normalization functions in
 entity-instances.ts

---
 src/entities/entity-instances.ts | 28 ++++++++--------------------
 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/src/entities/entity-instances.ts b/src/entities/entity-instances.ts
index 359d140b..2c6761d7 100644
--- a/src/entities/entity-instances.ts
+++ b/src/entities/entity-instances.ts
@@ -1293,17 +1293,6 @@ function normalizeNpcModelAssetId(
   return normalizedModelAssetId.length === 0 ? null : normalizedModelAssetId;
 }
 
-function normalizeNpcDialogueId(
-  dialogueId: string | null | undefined
-): string | null {
-  if (dialogueId === undefined || dialogueId === null) {
-    return null;
-  }
-
-  const normalizedDialogueId = dialogueId.trim();
-  return normalizedDialogueId.length === 0 ? null : normalizedDialogueId;
-}
-
 function normalizeNpcDialogues(
   dialogues: ProjectDialogue[] | undefined
 ): ProjectDialogue[] {
@@ -1316,14 +1305,15 @@ function normalizeNpcDialogues(
 
 function normalizeNpcDefaultDialogueId(
   defaultDialogueId: string | null | undefined,
-  dialogues: readonly ProjectDialogue[],
-  legacyDialogueId?: string | null | undefined
+  dialogues: readonly ProjectDialogue[]
 ): string | null {
-  const normalizedDefaultDialogueId = normalizeNpcDialogueId(
-    defaultDialogueId ?? legacyDialogueId ?? null
-  );
+  if (defaultDialogueId === undefined || defaultDialogueId === null) {
+    return null;
+  }
 
-  if (normalizedDefaultDialogueId === null) {
+  const normalizedDefaultDialogueId = defaultDialogueId.trim();
+
+  if (normalizedDefaultDialogueId.length === 0) {
     return null;
   }
 
@@ -1493,7 +1483,6 @@ export function createNpcEntity(
       | "defaultDialogueId"
     >
   > & {
-    dialogueId?: string | null;
     collider?: Partial<NpcColliderSettings>;
   } = {}
 ): NpcEntity {
@@ -1507,8 +1496,7 @@ export function createNpcEntity(
   const dialogues = normalizeNpcDialogues(overrides.dialogues);
   const defaultDialogueId = normalizeNpcDefaultDialogueId(
     overrides.defaultDialogueId ?? DEFAULT_NPC_DIALOGUE_ID,
-    dialogues,
-    overrides.dialogueId
+    dialogues
   );
   const collider = createNpcColliderSettings(overrides.collider);