From ef62aca806065acc12e725f63646561a5869f48a Mon Sep 17 00:00:00 2001
From: Victor Giers <mail@victorgiers.com>
Date: Tue, 14 Jul 2026 07:56:13 +0200
Subject: [PATCH] Update Ableton transformer logic for drum rack handling and
 group merging.

---
 src/lib/transformers/ableton.ts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/lib/transformers/ableton.ts b/src/lib/transformers/ableton.ts
index 8fee039..5a616f4 100644
--- a/src/lib/transformers/ableton.ts
+++ b/src/lib/transformers/ableton.ts
@@ -89,9 +89,11 @@ export type AblScene = {
 
 export function getDrumRackMidiNote(padCode: PadCode) {
   const padNumber = parseInt(padCode.slice(1), 10);
+  // EP133 is 3x4 (top→bottom), Ableton Drum Rack is 4x4 (bottom→top)
+  // flip vertically: row 3 → row 0, row 0 → row 3
   const row = 3 - Math.floor(padNumber / 3);
   const col = padNumber % 3;
-  return 36 + row * 4 + col;
+  return 36 + row * 4 + col; // remaping notes starting from C1 (36)
 }
 
 function getTrackNoteValues(track: AblTrack) {
@@ -291,6 +293,7 @@ function abletonTransformer(data: ProjectRawData, exporterParams: ExporterParams
     );
   }
 
+  // Helper function to create a drum rack track for a specific group
   const createDrumRackTrack = (group: 'a' | 'b' | 'c' | 'd'): AblTrack | null => {
     const groupTracksForDrumRack = tracks
       .filter((track) => track.group === group && track.sampleName)
@@ -337,6 +340,7 @@ function abletonTransformer(data: ProjectRawData, exporterParams: ExporterParams
       timeSignature: data.scenesSettings.timeSignature,
     };
 
+    // We need to merge notes from all tracks in the group into one track
     const newClips = new Map<number, AblClip>();
 
     drumTrack.tracks
@@ -378,6 +382,7 @@ function abletonTransformer(data: ProjectRawData, exporterParams: ExporterParams
     return drumTrack;
   };
 
+  // Process drum racks for each group that has the option enabled
   const drumRackTracks: AblTrack[] = [];
   if (exporterParams.includeArchivedSamples) {
     for (const group of ['a', 'b', 'c', 'd'] as const) {
@@ -390,6 +395,7 @@ function abletonTransformer(data: ProjectRawData, exporterParams: ExporterParams
     }
   }
 
+  // Insert drum rack tracks at the beginning, maintaining group order (A, B, C, D)
   tracks.unshift(...drumRackTracks);
 
   Sentry.setContext(`abletonData`, {